-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Task label feature #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task label feature #979
Conversation
for more information, see https://pre-commit.ci
|
Nice! For applying the |
for more information, see https://pre-commit.ci
…lel into task_label_feature
|
Thanks for the feedback.
|
|
with view.temp_flags(label="x"):
view.apply(f, a=b)If we want to come up with another nicer way to avoid |
optional: returing self in View.set_flags allowing compact list comprehension for setting labels
|
Thanks again for your feedback and pointing out the set In German we would say, the one who can read has a clear advantage ;-) Now knowing the This concept is used in some C++ libraries and would allow defining list comprehension (as in the example script). It should not break any existing code. If you don’t like this idea/concept I will remove the two By the way, do you like the idea of making the label also available in the AsyncResult objects? |
I managed to add/transfer the |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
I have added support for |
|
Sorry for the long gap, it's been a busy week! Thanks for sticking with it. The Don't worry about splitting stuff that's already done for mongo. I think you're right that we can probably safely require recent versions. It may be time to drop the mongo stuff, I'm not sure it's used these days. For setting the label on AsyncResult immediately, I think it makes sense, but if it's non-obvious how to do it in a clean way, we can open an Issue for that enhancement on its own. |
|
thanks very much for your reply and merging the code so quickly. To be honest I didn't expect that because there are several things that should be improved (from my point of view):
I'm happy to provide those things. Should I do this in a separate pull request? Regarding
Ok & thanks. I will have a look again... |
First version of adding a task label feature that is queryable in the hubDB as discussed in #914.
What's missing?